Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fud2] Cider is the default for --to dat computations #2208

Open
EclecticGriffin opened this issue Jul 15, 2024 · 5 comments
Open

[Fud2] Cider is the default for --to dat computations #2208

EclecticGriffin opened this issue Jul 15, 2024 · 5 comments
Labels
C: fud2 experimental driver

Comments

@EclecticGriffin
Copy link
Collaborator

It should probably be verilator for the sake of matching the original fud and for overall stability

@EclecticGriffin EclecticGriffin added the C: fud2 experimental driver label Jul 15, 2024
@sgpthomas
Copy link
Collaborator

I think defaults are decided based on the order that they are added. I think that the right solution to this problem is being able to explicitly declare priorities of operators. So that it doesn't depend on something rather opaque.

@EclecticGriffin
Copy link
Collaborator Author

Yeah I agree with that approach

@sampsyo
Copy link
Contributor

sampsyo commented Jul 30, 2024

We definitely need a way to do something about this so that the default paths are more obvious & predictable. The tracker (#1878) mentions priorities as a way about this, and it links to #1873 for further discussion. I will link the tracker to this issue as well as a specific instance of the prioritization problem, which we should perhaps fix even if we don't have a general scheme yet.

In general, however, I'm not 100% sure integer priority scores are the way… they are a little bit brittle and fiddly to manage. Maybe there's another way that we can ensure a deterministic order of op registration (including from Rhai files) that would allow this kind of control without scoring.

@sampsyo sampsyo mentioned this issue Jul 30, 2024
22 tasks
@rachitnigam
Copy link
Contributor

Maybe there's another way that we can ensure a deterministic order of op registration (including from Rhai files) that would allow this kind of control without scoring.

The downside is that this will require fiddling with Rhai for users who only care about using fud2 (instead of adding new stages, ops, etc.)

@sampsyo
Copy link
Contributor

sampsyo commented Jul 30, 2024

I think I understand what you're saying: the the user should also be able to specify what to prioritize. That wasn't what I was thinking of here; it was just that the fud2 developer should have a way to predictably induce the default that they want.

Separately, yeah, I guess it could also make sense to let users pick whether they want to behave like --through icarus or --through verilator as the default behavior, just by modifying their config file. But that seems like a somewhat more niche thing; it's more important that the default defaults be controllable by fud2 developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: fud2 experimental driver
Projects
None yet
Development

No branches or pull requests

4 participants