Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fud2 | Request] Cleanup the work directory on SIGINT #2154

Open
EclecticGriffin opened this issue Jun 17, 2024 · 1 comment
Open

[Fud2 | Request] Cleanup the work directory on SIGINT #2154

EclecticGriffin opened this issue Jun 17, 2024 · 1 comment
Labels
C: fud2 experimental driver

Comments

@EclecticGriffin
Copy link
Collaborator

I run into this issue a bunch when I'm running runt tests and kill the execution with CTRL-C since doing so leaves all the work directories lying around. I am not certain that runt will propagate the SIGINT but fud2 should still probably react appropriately when it receives one.

@EclecticGriffin EclecticGriffin added the C: fud2 experimental driver label Jun 17, 2024
@sampsyo
Copy link
Contributor

sampsyo commented Jun 19, 2024

Thanks; this is a good idea. I'm not 100% sure how to do this, but I think we probably want to handle SIGINT with signal-hook and somehow access some sort of mutable global state to find out if there is something to clean up. Then, we'll want to make sure that the Ninja subprocess also gets terminated when we then immediately exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: fud2 experimental driver
Projects
None yet
Development

No branches or pull requests

2 participants