You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of July 2022, calcom/docker has a branch protection rule on main that requires at least one review before merging. This revealed two bugs:
the submodule sync workflow stopped working
the submodule sync workflow reports a successful job even though it failed
The last step in the Actions workflow for submodule update ends with || echo. Because echo always exit 0, GitHub Actions erroneously believes the job succeeded regardless of whether git push failed due to lack of new commits or failure to push. See example. This has been failing since 1.7.6 cal.com@6b0ac9.
Instead of committing and pushing on one line, I would recommend separating the check for new commits to its own line. That way, you can do an early exit(0) if there are no new commits, and correctly fail the job if git push errors out.
To fix the issue with the branch protection rule, there are a few options. In no particular order:
As of July 2022, calcom/docker has a branch protection rule on
main
that requires at least one review before merging. This revealed two bugs:The last step in the Actions workflow for submodule update ends with
|| echo
. Becauseecho
always exit 0, GitHub Actions erroneously believes the job succeeded regardless of whethergit push
failed due to lack of new commits or failure to push. See example. This has been failing since 1.7.6 cal.com@6b0ac9.Instead of committing and pushing on one line, I would recommend separating the check for new commits to its own line. That way, you can do an early
exit(0)
if there are no new commits, and correctly fail the job ifgit push
errors out.To fix the issue with the branch protection rule, there are a few options. In no particular order:
git clone
in the docker build and push workflow.The text was updated successfully, but these errors were encountered: