Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-5041] Branding in workflow emails #18700

Open
CarinaWolli opened this issue Jan 15, 2025 · 6 comments · May be fixed by #18862
Open

[CAL-5041] Branding in workflow emails #18700

CarinaWolli opened this issue Jan 15, 2025 · 6 comments · May be fixed by #18862
Assignees
Labels
🐛 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync workflows area: workflows, automations
Milestone

Comments

@CarinaWolli
Copy link
Member

'Scheduling by cal.com' is still showing in workflow emails even when branding is disabled

From SyncLinear.com | CAL-5041

@CarinaWolli CarinaWolli self-assigned this Jan 15, 2025
@CarinaWolli CarinaWolli added High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jan 15, 2025
@dosubot dosubot bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email workflows area: workflows, automations labels Jan 15, 2025
@CarinaWolli CarinaWolli added this to the v4.10 milestone Jan 16, 2025
@sn10-debug
Copy link

I have been looking into this error even thought i am not assigned. Can you please allow me to solve this issue and if yes then in what scenario this is happening. What i have checked is that this message will not only be added into the email body if the USER schema has "hideBranding" is true. There might be issue about changing this attribute on successful payment.

@sn10-debug
Copy link

@CarinaWolli Can you comment please?

@CarinaWolli
Copy link
Member Author

Hey @sn10-debug, yes please feel free to work on it 🙏 I took a quick look at the code and I think the issue is that in many places we do not pass hideBranding when calling customTemplate().
Additionally, hideBranding is always taken from the user but instead, we need to check if it might be disabled on Organization or team level.

How should it be?

  • If user disabled branding --> Branding should be disabled for user workflows only
  • If team disabled branding --> Only team workflows have branding disabled (maybe have to rethink that, but for now that would be fine)
  • If Organization disabled branding --> Don't show branding for any workflows

@sn10-debug
Copy link

I have used the hideBranding key in the Team Schema for the Team Workflows branding to disable or not.

Just on the last step to confirm for the Organization Part

Planning to check the hideBranding key in the Parent Team for the Organization Workflows.

For the Organization , the User workflows that is Personal Workflows are also Disabled?

@CarinaWolli Please comment.

@CarinaWolli
Copy link
Member Author

For the Organization , the User workflows that is Personal Workflows are also Disabled?

Yes, if branding is disabled on organization level then any User or Team event type should have branding disabled

@sn10-debug
Copy link

@CarinaWolli Please comment on the Solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync workflows area: workflows, automations
Projects
None yet
2 participants