Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 - Return type issues #840

Open
jsandfordhughes opened this issue Jan 20, 2022 · 1 comment
Open

PHP 8.1 - Return type issues #840

jsandfordhughes opened this issue Jan 20, 2022 · 1 comment

Comments

@jsandfordhughes
Copy link

jsandfordhughes commented Jan 20, 2022

I am using this package with PHP 8.1 and while everything works correctly there are a few warnings that popup for interface compatibility.

The ones I have seen are the following:

Return type of XeroPHP\Remote\Model::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed

Return type of XeroPHP\Remote\Model::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool

Return type of XeroPHP\Remote\Model::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed

Return type of XeroPHP\Remote\Model::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void

Return type of XeroPHP\Remote\Model::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void

Happy to do a PR for these if nothing is in the pipeline?

@calcinai
Copy link
Owner

Yeah that would be great, thanks!

p4veI pushed a commit to p4veI/xero-php that referenced this issue Mar 21, 2022
@p4veI p4veI mentioned this issue Mar 21, 2022
p4veI pushed a commit to p4veI/xero-php that referenced this issue Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants