Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[story] Update story page #93

Merged
merged 20 commits into from
Apr 24, 2024
Merged

[story] Update story page #93

merged 20 commits into from
Apr 24, 2024

Conversation

emilysunaryo
Copy link
Contributor

What's new in this PR

New styling for story pages, fixed share button, created new component for list of authors, added image to story, did best to fix baseStyles, but ran into some bugs for some stories (could not fully override some styles for some reason - please look into this)

Relevant Links

Notion Sprint Task

Online sources

Related PRs

How to review

Next steps

  • added emoji reactions at the bottom of story but still need to add some icons for reactions
  • figure out why I can't override some base styling (cannot bold Author's Process text even if I try and use global styling)
  • could not figure out the regex logic for adding quotations to author excerpt, but I have my code trying to figure it out left over

Tests Performed, Edge Cases

Screenshots

Screenshot 2024-04-22 at 11 30 54 AM

CC: @adityapawar1

@adityapawar1 adityapawar1 merged commit ea30f15 into main Apr 24, 2024
1 check passed
@adityapawar1 adityapawar1 deleted the emily/storyStyling branch April 24, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants