Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Prevent users from navigating backwards during auth flow #24

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

adityapawar1
Copy link
Collaborator

@adityapawar1 adityapawar1 commented Oct 21, 2023

What's new in this PR

  • Replaced instances of router.push with router.replace for sign in
  • this doesn't add the screen to the navigation stack which doesn't let the user swipe back to a previous screen during login/sign up
  • Also fixed all eslint warnings

Notion Sprint Task

https://www.notion.so/calblueprint/auth-Prevent-users-from-navigating-backwards-during-auth-flow-61d3ab2485244b6c80349926e41de0d4?pvs=4

Online sources

Related PRs

  • None

How to review

  • Work through the signup flow from the start of the app and try swiping back to the previous page after a screen redirect. The intended behavior is that you should not be able to navigate backward until you get to the home/settings screen.
  • Do the same as above with the login flow.

Next steps

N/A

Tests Performed, Edge Cases

N/A

Screenshots

N/A

CC: @akshaynthakur

@akshaynthakur akshaynthakur marked this pull request as draft October 21, 2023 18:53
@adityapawar1 adityapawar1 marked this pull request as ready for review October 21, 2023 22:32
Copy link
Collaborator

@akshaynthakur akshaynthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome job as always

@akshaynthakur akshaynthakur merged commit 863013d into main Oct 21, 2023
2 checks passed
@akshaynthakur akshaynthakur deleted the adi/prevent-back-nav-auth branch December 1, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants