Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current State and Roadmap #25

Open
ravage84 opened this issue May 13, 2020 · 14 comments
Open

Current State and Roadmap #25

ravage84 opened this issue May 13, 2020 · 14 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@ravage84
Copy link
Member

The current state of this plugin isn't mentioned anywhere. Also, there is no roadmap, as it seems.

For example, there hasn't been a single release, yet. Not even an alpha release.

@ravage84 ravage84 added the documentation Improvements or additions to documentation label May 13, 2020
@ravage84 ravage84 added this to the 1.0.0 milestone May 13, 2020
@josegonzalez
Copy link
Member

josegonzalez commented May 13, 2020

Good call. I think @markstory had some ideas/things he wanted to implement before an initial release. Happy to dig into those as long as they are not testing related (I'm bad at that sorry not sorry).

@markstory
Copy link
Member

I would like to shore up some of the coverage gaps, and ensure we have at least a few end to end integration tests with one of the simple enqueue adapters before doing any releases.

As for a roadmap I can try to put something together later this week.

@markstory
Copy link
Member

markstory commented May 18, 2020

I had attempted to put the following in to the milestone description but GitHub butchers the formatting.

Initial release for the Queue Plugin.

Goals

  • Provide job consumer and Job classes to enable background job dispatching.
  • Provide bake templates for job classes.
  • Add Cake/ as top level namespace
  • Decide final package name.
  • Get to ~90% test coverage.
  • Include integration tests with end to end job execution.
  • Publish documentation.

@othercorey
Copy link
Member

I request adding "Move under Cake/ namespace".

@josegonzalez
Copy link
Member

I think I setup the plugin in the same way we have Migrations and Bake, neither of which have the Cake/ namespace. Feel free to change it up though if we've decided that official plugins should have that, core or not :)

@othercorey
Copy link
Member

I'm not going to make a big issue out of this, but my point-of-view is that we shouldn't be pushing things into the top-level namespace just because. I'm not a fan of the argument "well you shouldn't be using two queue systems in the first place.". Unless we're implementing de facto queue in php, our library names are too common.

@ADmad
Copy link
Member

ADmad commented May 19, 2020

I added Add Cake/ as top level namespace to markstory's comment above. Our TwigView plugin also has the same.

@josegonzalez
Copy link
Member

Sounds good :)

@markstory
Copy link
Member

The namespace changes are done now 😄

@T0mats0
Copy link

T0mats0 commented Oct 22, 2020

Looks like on the list is 90% coverage. We're almost there. QueueExtension needs a bit more. We also need end to end?
Without an integration test, I can't think of a way to to test QueueExtension without mocks. So what's left there?

We also talked about reducing static methods. I can imagine a lot here.

Documentation is left too. No idea what/how to write that up.

@markstory
Copy link
Member

@T0mats0 I think an end to end test for a successful job dispatch and execution would be great to have.

The documentation has been deployed and auto updates on each merge. It hasn't been linked into the make book table of contents as this plugin is still early on, but the docs are available at https://book.cakephp.org/queue

@ADmad ADmad pinned this issue Nov 17, 2020
@godgarden-dev
Copy link

I'm really looking forward to the release. Is it almost there?
Thank you for all your wonderful OSS development.

@markstory
Copy link
Member

I think we can do an initial release soon. The first batch of features are in place, and tests are much better than they were before.

@dereuromark
Copy link
Member

Once this is done and docs are added, maybe also add it to https://github.com/FriendsOfCake/awesome-cakephp#queue for visibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

8 participants