From 94956ae4c12c4f4b9b5650c59bbe1b9e1ccd14b6 Mon Sep 17 00:00:00 2001 From: Mark Scherer Date: Thu, 25 Jul 2024 11:54:24 +0200 Subject: [PATCH 1/2] Remove not needed cloaking check --- config/bootstrap.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/bootstrap.php b/config/bootstrap.php index 50055096e..2ef80806e 100644 --- a/config/bootstrap.php +++ b/config/bootstrap.php @@ -155,7 +155,7 @@ } $httpHost = env('HTTP_HOST'); - if (isset($httpHost)) { + if ($httpHost !== null) { $fullBaseUrl = 'http' . $s . '://' . $httpHost; } unset($httpHost, $s); From d260a48017e06ebca2f115cd1432964ab3768049 Mon Sep 17 00:00:00 2001 From: Mark Story Date: Thu, 25 Jul 2024 05:12:36 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Mark Scherer --- config/bootstrap.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/bootstrap.php b/config/bootstrap.php index 2ef80806e..14434ba0e 100644 --- a/config/bootstrap.php +++ b/config/bootstrap.php @@ -155,7 +155,7 @@ } $httpHost = env('HTTP_HOST'); - if ($httpHost !== null) { + if ($httpHost) { $fullBaseUrl = 'http' . $s . '://' . $httpHost; } unset($httpHost, $s);