Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Checking of Addins #27

Open
gep13 opened this issue Jun 27, 2018 · 2 comments
Open

Duplicate Checking of Addins #27

gep13 opened this issue Jun 27, 2018 · 2 comments

Comments

@gep13
Copy link
Member

gep13 commented Jun 27, 2018

With the new functionality that is provided by AddinDiscoverer to update and maintain the YAML files on the Cake Website, I think we have to start thinking about detecting duplicate addins.

For example, we have this:

https://www.nuget.org/packages/Cake.Aws.ElasticBeanstalk/

and this:

https://www.nuget.org/packages/Cake.Aws.ElasticBeanstalk.Dev/1.3.4-Dev

The second is clearly a duplicate of the first, and as such, I don't think it should be included. Ideally, this would be flagged, with an action for someone to follow up to try to figure out what is going on.

@Jericho
Copy link
Member

Jericho commented Jul 5, 2018

What would be the logic to determine that two nuget packages are potential duplicates?

Some ideas:

  • the name of the packages are "similar" (define similar)
  • they contain assemblies with the exact same name

@Jericho
Copy link
Member

Jericho commented Aug 31, 2018

By the way, the example you gave (Cake.Aws.ElasticBeanstalk vs Cake.Aws.ElasticBeanstalk.Dev) would be avoided if we excluded prerelease packages since Cake.Aws.ElasticBeanstalk.Dev is marked as prerelease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants