Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting prozess working with node 0.12.0 #53

Closed
wants to merge 1 commit into from
Closed

Getting prozess working with node 0.12.0 #53

wants to merge 1 commit into from

Conversation

BryanDonovan
Copy link

Fixes #52.

  • Bumped a couple npm versions (bignum and buffermaker).
  • Updated Consumer.js and its tests to check the port before trying to connect, otherwise node's net.js throws an untrapped RangeError.

For some reason the tests run much slower in 0.12.0, which is concerning.

Running the tests also prints out this warning:
child_process: customFds option is deprecated, use stdio instead.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) to 90.82% when pulling 64d34a3 on BryanDonovan:feature/node-0.12-support into 112e126 on cainus:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to compile in node 0.12.0
2 participants