This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
make octals explicit #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusvazquez
reviewed
Jun 6, 2019
There was a problem hiding this comment.
I investigated this issue in this MR #65 but for a different version of the module that was in use by @jihonrado. The change didn't work for them so we're taking advantage of it to finally migrate the instance out of terraform. That said we can probably merge this to be explicit. Good news are we're 1 instance away from deprecating the whole module.
diraol
force-pushed
the
master
branch
5 times, most recently
from
4cde372
to
1750752
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem:
https://gitlab.otters.xyz/product/data-engineering/terraform/prodops/-/jobs/731685
reason
I think it is required now in newest plugins, which was bumped in https://gitlab.otters.xyz/product/systems/dockerfiles/docker-ci-terraform/merge_requests/24
disclaimer
I don't speak k8s, please 👀 this one :)