We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As I known, the sync.Pool in golang , you must use get/put together. But the code below https://github.com/c4milo/gsync/blob/master/gsync_client.go#L109
you only bufferPool.Put(bfp) when the err is io.EOF, is this ok?
The text was updated successfully, but these errors were encountered:
I find that buffer from synt.Pool can be gc when the sync.Pool hold the only reference. https://golang.org/src/sync/pool.go line 17
But you should put the buffer to bufferPool event it can be gc outside.
Sorry, something went wrong.
@jannson, there is no memory leak as you found out. However, it does put pressure in the GC.
No branches or pull requests
As I known, the sync.Pool in golang , you must use get/put together. But the code below
https://github.com/c4milo/gsync/blob/master/gsync_client.go#L109
you only bufferPool.Put(bfp) when the err is io.EOF, is this ok?
The text was updated successfully, but these errors were encountered: