Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is lodash really being eager loaded? #30

Open
pechitook opened this issue Dec 2, 2016 · 2 comments
Open

Is lodash really being eager loaded? #30

pechitook opened this issue Dec 2, 2016 · 2 comments

Comments

@pechitook
Copy link

This was suposed to be taken care of in #21, but webpack-dashboard management of dependencies, which I believe comes from webpack ouput itself states otherwise:

image

Is there any chance anyone else could confirm this? @byronmwong @gianu @rafaelchiti

@bywo
Copy link
Owner

bywo commented Dec 2, 2016

Hey, thanks for filing the issue! I found another place where I was importing all of lodash and removed it. Can you try again with version 1.2.5?

Here's what I'm getting now, definitely better, but still larger than I'd like.

react-flexbox-layout: 201 KB (4.31%)
  lodash: 119.98 KB (59.7%)
  classnames: 1.08 KB (0.535%)
  <self>: 79.94 KB (39.8%)

@pechitook
Copy link
Author

That's a great improvement. Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants