feat: esbuild

Author: transitive-bullshit

.gitignore

@@ -15,11 +15,12 @@ dist
 .env.test.local
 .env.production.local
 .cache
+tsconfig.tsbuildinfo
 
 npm-debug.log*
 yarn-debug.log*
 yarn-error.log*
-.vscode/settings.json
+.vscode/settings.json
 
 .next/
 .vercel/

examples/full/lib/config.ts

@@ -1,7 +1,8 @@
 // TODO: change these to your own values
 // NOTE: rootNotionSpaceId is optional; set it to undefined if you don't want to
 // use it.
-export const rootNotionPageId = '067dd719a912471ea9a3ac10710e7fdf'
+// export const rootNotionPageId = '067dd719a912471ea9a3ac10710e7fdf'
+export const rootNotionPageId = '2fea615a97a7401c81be486e4eec2e94'
 export const rootNotionSpaceId = 'fde5ac74-eea3-4527-8f00-4482710e1af3'
 
 // NOTE: having this enabled can be pretty expensive as it re-generates preview

examples/full/pages/[pageId].tsx

@@ -27,7 +27,8 @@ export const getStaticProps = async (context) => {
 }
 
 export async function getStaticPaths() {
-  if (isDev) {
+  const no = true
+  if (isDev || no) {
     return {
       paths: [],
       fallback: true

package.json

@@ -14,8 +14,10 @@
     "examples/*"
   ],
   "scripts": {
-    "build": "lerna run build --no-private",
-    "watch": "tsc --watch",
+    "build": "run-s build:tsc build:bundle",
+    "build:tsc": "tsc --build",
+    "build:bundle": "lerna run bundle --no-private",
+    "watch": "tsc --build tsconfig.json --watch",
     "dev": "run-s watch",
     "prebuild": "run-s clean",
     "prewatch": "run-s clean",
@@ -39,6 +41,7 @@
     "ava": "^4.1.0",
     "del-cli": "^4.0.1",
     "esbuild": "^0.14.27",
+    "esbuild-node-externals": "^1.4.1",
     "eslint": "^8.11.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-react": "^7.29.4",
@@ -50,6 +53,7 @@
     "npm-run-all": "^4.1.5",
     "prettier": "^2.6.0",
     "ts-node": "^10.7.0",
+    "tsup": "^5.12.1",
     "typescript": "^4.6.2"
   },
   "lint-staged": {

packages/notion-client/package.json

@@ -6,15 +6,14 @@
   "repository": "NotionX/react-notion-x",
   "author": "Travis Fischer <[email protected]>",
   "license": "MIT",
-  "source": "./src/index.ts",
   "module": "./build/index.js",
   "typings": "./build/index.d.ts",
   "sideEffects": false,
   "engines": {
     "node": ">=12"
   },
   "scripts": {
-    "build": "microbundle -f esm --no-compress -i src/index.ts -o build/index.js --no-pkg-main",
+    "bundle": "esbuild src/index.ts --bundle --outdir=build --format=esm --sourcemap --target=node12 --platform=node --external:./node_modules/*",
     "test": "ava 'build/**/*.test.js'"
   },
   "dependencies": {

packages/notion-client/src/notion-api.ts

@@ -158,6 +158,7 @@ export class NotionAPI {
             // It's possible for public pages to link to private collections, in which case
             // Notion returns a 400 error
             console.warn('NotionAPI collectionQuery error', err.message)
+            console.error(err)
           }
         },
         {
@@ -336,6 +337,7 @@ export class NotionAPI {
           property,
           value: { value, type }
         } = group
+
         for (const iterator of iterators) {
           const iteratorProps =
             iterator === 'results'

packages/notion-client/tsconfig.json

@@ -3,7 +3,9 @@
   "compilerOptions": {
     "composite": true,
     "rootDir": "src",
-    "outDir": "build"
+    "outDir": "build",
+    "tsBuildInfoFile": "build/.tsbuildinfo",
+    "emitDeclarationOnly": true
   },
   "include": ["src"],
   "references": [{ "path": "../notion-types" }, { "path": "../notion-utils" }]

packages/notion-types/package.json

@@ -6,14 +6,9 @@
   "repository": "NotionX/react-notion-x",
   "author": "Travis Fischer <[email protected]>",
   "license": "MIT",
-  "source": "./src/index.ts",
-  "module": "./build/index.js",
   "typings": "./build/index.d.ts",
   "sideEffects": false,
   "engines": {
     "node": ">=12"
-  },
-  "scripts": {
-    "build": "microbundle -f esm --no-compress -i src/index.ts -o build/index.js --no-pkg-main"
   }
 }

packages/notion-types/tsconfig.json

@@ -3,7 +3,9 @@
   "compilerOptions": {
     "composite": true,
     "rootDir": "src",
-    "outDir": "build"
+    "outDir": "build",
+    "tsBuildInfoFile": "build/.tsbuildinfo",
+    "emitDeclarationOnly": true
   },
   "include": ["src"]
 }

packages/notion-utils/package.json

@@ -6,7 +6,6 @@
   "repository": "NotionX/react-notion-x",
   "author": "Travis Fischer <[email protected]>",
   "license": "MIT",
-  "source": "./src/index.ts",
   "module": "./build/index.js",
   "typings": "./build/index.d.ts",
   "exports": {
@@ -20,7 +19,7 @@
     "node": ">=12"
   },
   "scripts": {
-    "build": "microbundle -f esm --no-compress -i src/index.ts -o build/index.js --no-pkg-main",
+    "bundle": "esbuild src/index.ts --bundle --outdir=build --format=esm --sourcemap --external:./node_modules/*",
     "test": "ava"
   },
   "dependencies": {

packages/notion-utils/tsconfig.json

@@ -4,9 +4,8 @@
     "composite": true,
     "rootDir": "src",
     "outDir": "build",
-    "paths": {
-      "notion-types": ["../notion-types"]
-    }
+    "tsBuildInfoFile": "build/.tsbuildinfo",
+    "emitDeclarationOnly": true
   },
   "include": ["src"],
   "references": [{ "path": "../notion-types" }]

packages/react-notion-x/package.json

@@ -6,21 +6,20 @@
   "repository": "NotionX/react-notion-x",
   "author": "Travis Fischer <[email protected]>",
   "license": "MIT",
-  "source": "./src/index.tsx",
   "module": "./build/index.js",
   "typings": "./build/index.d.ts",
   "sideEffects": false,
   "engines": {
     "node": ">=12"
   },
   "scripts": {
-    "build": "run-s build:*",
-    "build:index": "microbundle -f esm --no-compress -i src/index.tsx -o build/index.js --no-pkg-main",
-    "build:code": "microbundle -f esm --no-compress -i src/third-party/code.tsx -o build/third-party/code.js --no-pkg-main",
-    "build:collection": "microbundle -f esm --no-compress -i src/third-party/collection.tsx -o build/third-party/collection.js --no-pkg-main",
-    "build:equation": "microbundle -f esm --no-compress -i src/third-party/equation.tsx -o build/third-party/equation.js --no-pkg-main",
-    "build:modal": "microbundle -f esm --no-compress -i src/third-party/modal.tsx -o build/third-party/modal.js --no-pkg-main",
-    "build:pdf": "microbundle -f esm --no-compress -i src/third-party/pdf.tsx -o build/third-party/pdf.js --no-pkg-main"
+    "bundle": "run-s bundle:*",
+    "bundle:index": "esbuild src/index.tsx --bundle --outdir=build --format=esm --sourcemap --target=es2015 --external:./node_modules/*",
+    "bundle:code": "esbuild src/third-party/code.tsx --bundle --outdir=build/third-party --format=esm --sourcemap --target=es2015 --external:./node_modules/*",
+    "bundle:collection": "esbuild src/third-party/collection.tsx --bundle --outdir=build/third-party --format=esm --sourcemap --target=es2015 --external:./node_modules/*",
+    "bundle:equation": "esbuild src/third-party/equation.tsx --bundle --outdir=build/third-party --format=esm --sourcemap --target=es2015 --external:./node_modules/*",
+    "bundle:modal": "esbuild src/third-party/modal.tsx --bundle --outdir=build/third-party --format=esm --sourcemap --target=es2015 --external:./node_modules/*",
+    "bundle:pdf": "esbuild src/third-party/pdf.tsx --bundle --outdir=build/third-party --format=esm --sourcemap --target=es2015 --external:./node_modules/*"
   },
   "dependencies": {
     "@matejmazur/react-katex": "^3.1.3",

packages/react-notion-x/tsconfig.json

@@ -4,6 +4,8 @@
     "composite": true,
     "rootDir": "src",
     "outDir": "build",
+    "tsBuildInfoFile": "build/.tsbuildinfo",
+    "emitDeclarationOnly": true,
     "lib": ["DOM", "ESNext"],
     "noImplicitReturns": false,
     "skipLibCheck": true,