Skip to content

Minimum Rust badge seems incorrect #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Voultapher opened this issue Nov 8, 2020 · 2 comments
Closed

Minimum Rust badge seems incorrect #2377

Voultapher opened this issue Nov 8, 2020 · 2 comments

Comments

@Voultapher
Copy link
Contributor

Voultapher commented Nov 8, 2020 •
edited
Loading

Just tried building the cranelift tests with cd cranelift && cargo test --all using Rust 1.44 and it failed building one of the dependencies because it wanted to use this dtolnay/proc-macro2#228. After upgrading to 1.47 everything works as expected. The top level README has a Rust 1.37+ badge. Either that is wrong or misleading.

Edit: Actually I need nightly to build and run the tests. I suggest we put that in the relevant README.
@alexcrichton
Copy link
Member

Ah yes I think that's a mistake, sorry about that! A PR would be welcome to clarify and update this!

@Voultapher Voultapher mentioned this issue Nov 10, 2020
Closed
@Voultapher
Copy link
Contributor Author

This issue hasn't seen activity in long time so I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @Voultapher