Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when dropping a fresh group #2

Open
ratchetfreak opened this issue Mar 18, 2021 · 4 comments
Open

crash when dropping a fresh group #2

ratchetfreak opened this issue Mar 18, 2021 · 4 comments

Comments

@ratchetfreak
Copy link

steps to recreate

  1. start fresh
  2. click the plus below the graph
  3. start dragging the hello that appear in the new branch
  4. drop it outside the graph
  5. observe crash

having a drag outside to delete would be nice instead of crash

@ratchetfreak
Copy link
Author

testing further it also crashes when you drag everything in a alternative to anywhere on the graph

@bvisness
Copy link
Owner

Yep, I've seen this before - fun fact, when I showed my coworker, the very first thing he did was perfectly reproduce this bug 🙃

What's happening is that I automatically delete empty union branches when they lose focus, but this means that when you drag away a full expression, the original location gets deleted. Then when you drop it in an invalid place, I try to put it back.

@ratchetfreak
Copy link
Author

you shouldn't be deleting empty union branches though because they are necessary for doing (stuff)? when there are 2 empty unions that start and end on the same point then sure delete the extra one.

@bvisness
Copy link
Owner

Yep, for sure, it's just a holdover from an earlier time. At this point my keyboard editing stuff is good enough that I think I can just render an empty expression state and not automatically remove anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants