You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, great library, thanks so much for your work on it!
This is pretty small but I noticed that the values for a few data attributes seem to not update correctly in an edge case where the handle is dragged and the mouse goes off of the window before releasing. This is at least true for data-resize-handle-state and data-resize-handle-active but it could be true for others as well (don't know enough to verify).
To reproduce
simply drag a resize handle and, before letting go, move your mouse off of the window, then release. This occurs with your sandbox example.
Details
One particularity which hopefully will make sense to you: I am seeing different behavior in different environments.
in your sandbox example, the values simply do not update when released out of the window (at least on chrome where I tried it)
in electron (where I am mostly working), the data-resize-handle-active disappears as expected on mouseup, but the data-resize-handle-state changes from 'drag' to 'hover' instead of changing to 'inactive'.
In all cases, the values immediately correct themselves the second the mouse reenters the window
At a very quick glance may be related to issue #368 but not sure.
Very small nit so I'm hoping it's an easy fix if there is one
The text was updated successfully, but these errors were encountered:
Hi, great library, thanks so much for your work on it!
This is pretty small but I noticed that the values for a few data attributes seem to not update correctly in an edge case where the handle is dragged and the mouse goes off of the window before releasing. This is at least true for
data-resize-handle-state
anddata-resize-handle-active
but it could be true for others as well (don't know enough to verify).To reproduce
simply drag a resize handle and, before letting go, move your mouse off of the window, then release. This occurs with your sandbox example.
Details
One particularity which hopefully will make sense to you: I am seeing different behavior in different environments.
data-resize-handle-active
disappears as expected on mouseup, but thedata-resize-handle-state
changes from'drag'
to'hover'
instead of changing to'inactive
'.In all cases, the values immediately correct themselves the second the mouse reenters the window
At a very quick glance may be related to issue #368 but not sure.
Very small nit so I'm hoping it's an easy fix if there is one
The text was updated successfully, but these errors were encountered: