Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoordinateSet trait: get_coord/set_coord should be get/set #104

Closed
busstoptaktik opened this issue Mar 29, 2024 · 1 comment
Closed

CoordinateSet trait: get_coord/set_coord should be get/set #104

busstoptaktik opened this issue Mar 29, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@busstoptaktik
Copy link
Owner

busstoptaktik commented Mar 29, 2024 •
edited
Loading

According to the Rust API guidelines, when only one thing could be reasonably gotten/sat, the corresponding methods should be named get and set respectively.

Hence the CoordinateSet methods get_coord(i) and set_coord(i, value) should be deprecated, replaced by get(i) and set(i, value), and eventually removed.
@busstoptaktik busstoptaktik added enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2024
@busstoptaktik
Copy link
Owner Author

Closing, since this is only marginally relevant with the introduction of more accessors in PRs #103 and #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@busstoptaktik