Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests Need Love #4

Open
flwyd opened this issue Dec 23, 2018 · 2 comments
Open

Integration Tests Need Love #4

flwyd opened this issue Dec 23, 2018 · 2 comments
Assignees
Labels
Bug Existing functionality not behaving as it should Task Needs doing

Comments

@flwyd
Copy link
Contributor

flwyd commented Dec 23, 2018

ember test --filter="integration" gets a whole lot of failures. It looks like a lot of component tests have autogenerated content, so they're creating a component without much backing data and then asserting that its text is empty. These errors frequently look like Global error: Uncaught TypeError: Cannot read property 'startsWith' of undefined if the template assumes data is present but the test doesn't set any. Or it looks like Actual: > Some text Expected: > (empty string) if the template renders properly but the test was never updated with an appropriate expectation. There are also a handful of ch-form errors with an assertion error like You specified a quoteless path, `cancelAction`, to the {{action}} helper which did not resolve to an action name (a string). Perhaps you meant to use a quoted actionName? (e.g. {{action "cancelAction"}}).

flwyd added a commit that referenced this issue Dec 23, 2018
@wsanchez wsanchez added the Bug Existing functionality not behaving as it should label Mar 7, 2019
@wsanchez wsanchez added this to the 2019 Burning Man Event milestone Mar 7, 2019
@wsanchez wsanchez removed this from the 2019 Burning Man Event milestone Sep 24, 2019
@flwyd flwyd added the Task Needs doing label Oct 18, 2019
@wsanchez wsanchez added this to the 2020 Burning Man Event milestone Oct 18, 2019
@wsanchez
Copy link
Member

We need to 1) get the tests working and then 2) tell me that command to run in CI.

@wsanchez
Copy link
Member

ember test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Existing functionality not behaving as it should Task Needs doing
Projects
None yet
Development

No branches or pull requests

3 participants