Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while converting String to Data during the loading of outdated packages swallows the error #353

Closed
buresdv opened this issue Jun 21, 2024 · 1 comment
Closed

Error while converting String to Data during the loading of outdated packages swallows the error #353

buresdv opened this issue Jun 21, 2024 · 1 comment
Labels
Enhancement New feature or request

Comments

@buresdv
Copy link
Owner

buresdv commented Jun 21, 2024

When loading outdated packages, in case there's an error converting the String terminal output to Data, the error gets throws, but is then swallowed and never shown in the UI.

Implement a displayable alert for this state, plus a notification.

Relevant lines

Cork/Cork/Views/Start Page/Start Page.swift

Line 131 in eedaac5

case .couldNotDecodeCommandOutput(let decodingError):

Cork/Cork/Views/Updating/Complete Updating/Sub-Views/States/Updating Package Tracker.swift

Line 52 in eedaac5

case .couldNotDecodeCommandOutput(let decodingError):

@buresdv buresdv added the Enhancement New feature or request label Jun 21, 2024
@buresdv buresdv moved this from Ideas to Todo in Cork Project Board Jun 21, 2024
@buresdv
Copy link
Owner Author

buresdv commented Jan 26, 2025

Implemented in ec9bec7

@buresdv buresdv closed this as completed Jan 26, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in This Release in Cork Project Board Jan 26, 2025
@buresdv buresdv moved this from Done in This Release to Done in Cork Project Board Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
Cork Project Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@buresdv