Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same content for both if & else #172

Open
siarheisinelnikau opened this issue Jul 2, 2023 · 3 comments
Open

Same content for both if & else #172

siarheisinelnikau opened this issue Jul 2, 2023 · 3 comments

Comments

@siarheisinelnikau
Copy link

@bupticybee there might be an issue:

if (i == cardr) {

@bupticybee
Copy link
Owner

Hi, the code is there,yes, but it's not used in any way. Warmup just don't work as I excepted.

And the code was written two yeas ago, I don't know what these lines does anyways. If you have any idea where it's wrong, could you create a PR or describe it in detail?

@siarheisinelnikau
Copy link
Author

siarheisinelnikau commented Jul 3, 2023

Thanks for quick response.

I'm just trying to understand the overall logic of what is going on there, so don't know how to change it correctly either (yet!).
Seems that PCfrSolver is very similar to BestResponse class, so it more looks like "copy/paste" issue.

@bupticybee
Copy link
Owner

Thanks for quick response.

I'm just trying to understand the overall logic of what is going on there, so don't know how to change it correctly either (yet!). Seems that PCfrSolver is very similar to BestResponse class, so it more looks like "copy/paste" issue.

Okay, that code you mentioned is a logic for a experimental feature(warmup). That feature is not active in current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants