Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Proposed fix for Unit definition #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Proposed fix for Unit definition #26

wants to merge 2 commits into from

Conversation

SergejMuhic
Copy link

@SergejMuhic SergejMuhic commented Sep 26, 2021 •
edited
Loading

Fixes:
Fixes #9

#22

Changes:
Created a new Unit element in units of type=ifc:IfcUnit

Attention:

  1. I was a bit confused with the existing definition and could not narrow down the intention. It could be that the proposed fix does not address the requirement.
  2. Verify by compiling the xsd

@SergejMuhic SergejMuhic self-assigned this Sep 26, 2021
@SergejMuhic SergejMuhic linked an issue Sep 26, 2021 that may be closed by this pull request
mvdXML 1.2 reference to IfcUnit #22
Open
pjanck
pjanck reviewed Sep 27, 2021
View reviewed changes
Copy link
Contributor

@pjanck pjanck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify by compiling the xsd

I'm trying to get it to run, no success yet. Will keep you posted.

@pjanck
Copy link
Contributor

pjanck commented Sep 27, 2021

Right, enabling this in IDE recognises the schema:

grafik

Now, the type https://standards.buildingsmart.org/IFC/RELEASE/IFC4/Add2TC1:IfcUnit is not declared, which is peculiar. Investigating further.

pjanck
pjanck suggested changes Sep 27, 2021
View reviewed changes
mvdXML1.2/xsd/mvdXML_V1-2_Draft9.xsd
Comment on lines +168 to +172
<xs:annotation>
<xs:documentation>
A Unit element of type IfcUnit from the IFC4 specification.
</xs:documentation>
</xs:annotation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an inner element of the xs:element and not xs:complexType.

@pjanck
Copy link
Contributor

pjanck commented Sep 28, 2021

As it stands today, the IFC schema referenced has a problem and is not serializable as well. Investigating further with @SergejMuhic and @apinzenoehler .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjanck pjanck pjanck requested changes

@MatthiasWeise MatthiasWeise Awaiting requested review from MatthiasWeise

Assignees

@SergejMuhic SergejMuhic

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mvdXML 1.2 reference to IfcUnit mvdXML v1.2 schema problems no.2?
2 participants
@SergejMuhic @pjanck