Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IfcConstructionResource omitted BaseQuantity means costs are total? #910

Open
Andrej730 opened this issue Nov 11, 2024 · 0 comments
Open

IfcConstructionResource omitted BaseQuantity means costs are total? #910

Andrej730 opened this issue Nov 11, 2024 · 0 comments

Comments

@Andrej730
Copy link
Contributor

In IfcCostItem.CostValues it says that if CostQuantities are not provided then values indicate total costs.
https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcCostItem.htm

image

IfcConstructionResource also has the values and quantities and both can be omitted to but it doesn't explicitly say that omitted quantities mean that costs are total and costs are described as "unit costs".
Does it mean shouldn't be treated as a total cost if quantity is omitted or it's just an overlook of the documentation?
image
Andrej730 added a commit to IfcOpenShell/IfcOpenShell that referenced this issue Nov 11, 2024
@Andrej730
calculate_cost_item_resource_value not to skip resources without quan…
c409258 
…tities

Noticed the discrepancies for total cost value for resources in Resource UI and in Cost Schedule UI when the same resources assigned to the item. In Resource UI it was considering omitted quantity as 1.0 (https://github.com/IfcOpenShell/IfcOpenShell/blob/c61e3670a8cf248aa5a229bae2dc29eef041fe47/src/ifcopenshell-python/ifcopenshell/util/cost.py#L53-L55) and in Cost Schedule UI it was skipping those resources completely.

For cost items it is documented in ifc that if quantity is omitted then costs are considered to be total. Perhaps it's just not documented for the resources? Anyway, not sure if this way is completly correct but making sure resource quantity to be treated similarly in different parts of the codebase.

Related to - buildingSMART/IFC4.3.x-development#910
cc @myoualid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andrej730