From e2913f86d793aa6008a6da2df1f9470c97b926fb Mon Sep 17 00:00:00 2001 From: Josh Edney Date: Tue, 26 Nov 2024 18:59:17 +0000 Subject: [PATCH 1/4] fix: correct case for setting bundleId --- lib/maze/client/appium/base_client.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/maze/client/appium/base_client.rb b/lib/maze/client/appium/base_client.rb index 8336ddc08..f19089fe0 100644 --- a/lib/maze/client/appium/base_client.rb +++ b/lib/maze/client/appium/base_client.rb @@ -23,11 +23,16 @@ def start_session Maze.driver.session_capabilities['appPackage'] when 'ios' unless app_id = Maze.driver.session_capabilities['CFBundleIdentifier'] - app_id = Maze.driver.session_capabilities['bundleID'] + app_id = Maze.driver.session_capabilities['bundleId'] end app_id end + if Maze.driver.app_id.nil? + $logger.error "Failed to determine app id." + $logger.debug "Capabilities: #{Maze.driver.session_capabilities.inspect}" + end + # Ensure the device is unlocked begin Maze.driver.unlock From 1ab721ab158dd015fda3c3e41c2badd45d1d132c Mon Sep 17 00:00:00 2001 From: Josh <46817760+joshedney@users.noreply.github.com> Date: Wed, 27 Nov 2024 08:31:01 +0000 Subject: [PATCH 2/4] Update lib/maze/client/appium/base_client.rb Co-authored-by: Steve Kirkland --- lib/maze/client/appium/base_client.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/maze/client/appium/base_client.rb b/lib/maze/client/appium/base_client.rb index f19089fe0..2254f8ce6 100644 --- a/lib/maze/client/appium/base_client.rb +++ b/lib/maze/client/appium/base_client.rb @@ -30,7 +30,7 @@ def start_session if Maze.driver.app_id.nil? $logger.error "Failed to determine app id." - $logger.debug "Capabilities: #{Maze.driver.session_capabilities.inspect}" + $logger.debug "session_capabilities: #{Maze.driver.session_capabilities.inspect}" end # Ensure the device is unlocked From 33753c00634d1be8f02af3cc35a4b20234d67810 Mon Sep 17 00:00:00 2001 From: Josh Edney Date: Wed, 27 Nov 2024 08:56:30 +0000 Subject: [PATCH 3/4] bump version --- CHANGELOG.md | 6 ++++++ lib/maze.rb | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fe59eded8..1ad914671 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +# 9.21.0 - 2024/11/27 + +## Fixes + +- Fix issue where the incorrect `buildId` was being pulled from `Maze.driver.session_capabilities` [707](https://github.com/bugsnag/maze-runner/pull/707) + # 9.20.0 - 2024/11/21 ## Enhancements diff --git a/lib/maze.rb b/lib/maze.rb index 6b7817a07..577ef67cb 100644 --- a/lib/maze.rb +++ b/lib/maze.rb @@ -7,7 +7,7 @@ # Glues the various parts of MazeRunner together that need to be accessed globally, # providing an alternative to the proliferation of global variables or singletons. module Maze - VERSION = '9.20.0' + VERSION = '9.21.0' class << self attr_accessor :check, :driver, :internal_hooks, :mode, :start_time, :dynamic_retry, :public_address, From 7dff86c1621fef183436b88912f446db70ed263d Mon Sep 17 00:00:00 2001 From: Josh Edney Date: Wed, 27 Nov 2024 10:36:40 +0000 Subject: [PATCH 4/4] adjust maze runner version --- CHANGELOG.md | 2 +- lib/maze.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ad914671..5788b66da 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -# 9.21.0 - 2024/11/27 +# 9.20.1- 2024/11/27 ## Fixes diff --git a/lib/maze.rb b/lib/maze.rb index 577ef67cb..2aa8b4012 100644 --- a/lib/maze.rb +++ b/lib/maze.rb @@ -7,7 +7,7 @@ # Glues the various parts of MazeRunner together that need to be accessed globally, # providing an alternative to the proliferation of global variables or singletons. module Maze - VERSION = '9.21.0' + VERSION = '9.20.1' class << self attr_accessor :check, :driver, :internal_hooks, :mode, :start_time, :dynamic_retry, :public_address,