Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully test and fix types in StringFormat implementation #257

Open
stefanvanburen opened this issue Feb 19, 2025 · 0 comments
Open

Fully test and fix types in StringFormat implementation #257

stefanvanburen opened this issue Feb 19, 2025 · 0 comments

Comments

@stefanvanburen
Copy link
Member

Our current StringFormat implementation is balking at the cel-python types we're using. Additionally, the protovalidate-conformance suite only really tests the %s verb, so we ought to have tests over the rest of the verbs.

The cel-spec test suite for formatting can be found here: https://github.com/google/cel-spec/blob/master/tests/simple/testdata/string_ext.textproto. Here is cel-go's explanation of how format should work.

Additionally, while we currently can add these tests in-repo, it'd behoove us to contribute a conformant implementation upstream to cel-python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant