Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gofeatures module #808

Closed
unmultimedio opened this issue Dec 24, 2024 · 3 comments · Fixed by #861
Closed

Deprecate gofeatures module #808

unmultimedio opened this issue Dec 24, 2024 · 3 comments · Fixed by #861
Assignees

Comments

@unmultimedio
Copy link
Member

We can deprecate gofeatures and fold it into wellknowntypes. cc @pkwarren @jhump

Copy link
Member Author

unmultimedio commented Feb 5, 2025

The latest synced version of gofeatures already includes a buf.md with a deprecation notice, redirecting to the WKT modules instead. Eg: https://buf.build/protocolbuffers/gofeatures

@jhump
Copy link
Member

jhump commented Feb 5, 2025

@unmultimedio, does that mean we can now safely delete the gofeatures module from this repo (to stop it sync'ing any future versions)?

@unmultimedio
Copy link
Member Author

unmultimedio commented Feb 5, 2025

@unmultimedio, does that mean we can now safely delete the gofeatures module from this repo (to stop it sync'ing any future versions)?

I need to first clean up some bits from the BSR's code, and then we can drop it from here 😄 . It's already commented out from the sync script, so it's not syncing new releases anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants