From 271721df70245f3d157aeec5645d34fc852f8aea Mon Sep 17 00:00:00 2001 From: Andrew Parmet Date: Fri, 20 Sep 2024 12:26:36 -0400 Subject: [PATCH] further simplify --- .../kotlin/build/buf/gradle/LintWithProtobufGradleTest.kt | 8 -------- .../buf.yaml | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/test/kotlin/build/buf/gradle/LintWithProtobufGradleTest.kt b/src/test/kotlin/build/buf/gradle/LintWithProtobufGradleTest.kt index 6bdd30d0..efb18244 100644 --- a/src/test/kotlin/build/buf/gradle/LintWithProtobufGradleTest.kt +++ b/src/test/kotlin/build/buf/gradle/LintWithProtobufGradleTest.kt @@ -14,10 +14,7 @@ package build.buf.gradle -import com.google.common.truth.Truth.assertThat -import org.gradle.language.base.plugins.LifecycleBasePlugin.CHECK_TASK_NAME import org.junit.jupiter.api.Test -import java.nio.file.Paths class LintWithProtobufGradleTest : ConfigOverrideableLintTests, AbstractLintTest() { @Test @@ -47,11 +44,6 @@ class LintWithProtobufGradleTest : ConfigOverrideableLintTests, AbstractLintTest @Test fun `lint a file with an implementation dependency and a lint config with the protobuf-gradle-plugin`() { - val result = gradleRunner().withArguments(":$CHECK_TASK_NAME").buildAndFail() - assertThat(result.output).contains("Enum zero value name \"BROKEN_ENUM_NONSPECIFIED\" should be suffixed with \"_UNSPECIFIED\"") - - Paths.get(projectDir.path, "buf.yaml").toFile().replace("#", "") - assertSuccess() } } diff --git a/src/test/resources/LintWithProtobufGradleTest/lint_a_file_with_an_implementation_dependency_and_a_lint_config_with_the_protobuf_gradle_plugin/buf.yaml b/src/test/resources/LintWithProtobufGradleTest/lint_a_file_with_an_implementation_dependency_and_a_lint_config_with_the_protobuf_gradle_plugin/buf.yaml index 123566cf..125fb1a8 100644 --- a/src/test/resources/LintWithProtobufGradleTest/lint_a_file_with_an_implementation_dependency_and_a_lint_config_with_the_protobuf_gradle_plugin/buf.yaml +++ b/src/test/resources/LintWithProtobufGradleTest/lint_a_file_with_an_implementation_dependency_and_a_lint_config_with_the_protobuf_gradle_plugin/buf.yaml @@ -6,4 +6,4 @@ lint: use: - DEFAULT except: - #- ENUM_ZERO_VALUE_SUFFIX + - ENUM_ZERO_VALUE_SUFFIX