Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group and Usuer top menu border elements not availalbe #205

Open
Saylrman64 opened this issue Nov 14, 2017 · 5 comments
Open

Group and Usuer top menu border elements not availalbe #205

Saylrman64 opened this issue Nov 14, 2017 · 5 comments

Comments

@Saylrman64
Copy link

Hello,

Note this should be labeled Help Wanted, but I either do not have that permission or I cannot find it.

First off, this is coming along very nice and I like most everything about it.

I'm evaluating this plugin on my test site and I've come across anomaly I'd like to point out.
I'm working with customizing the menu tabs and submenu tabs.
I've found that there are no css elements for the main or top menu tab for groups or users views when Set primary nav to tab style and Set User nav to tab style are enabled.

It may be that these have not been implemented but I suspect that since the submenu tab feature is working, there is either something wrong I'm missing something.

I've checked with several standard WP themes like Twenty Seventeen and they do not show up or I cannot find them. It does looks like the elements are there for vertical tabs on main menu.

Any guidance or help is appreciated.

Sub Menu Tab elements
.buddypress-wrap .item-body .tabbed-links ul li.current {
border-color: #ccc #ccc #fff;
border-style: solid;
border-top-left-radius: 4px;
border-top-right-radius: 4px;
border-width: 1px;
margin-bottom: -1px;
padding: 0 .5em;
}

@renatonascalves
Copy link
Member

What a title! :/

@Saylrman64
Copy link
Author

Saylrman64 commented Nov 14, 2017

Ugh!

Thanks.

@Saylrman64 Saylrman64 changed the title .buddypress-wrap .item-body .tabbed-links ul li.current { border-color: #ccc #ccc #fff; border-style: solid; border-top-left-radius: 4px; border-top-right-radius: 4px; border-width: 1px; margin-bottom: -1px; padding: 0 .5em; } Group and Usuer top menu border elements not availalbe Nov 14, 2017
@hnla
Copy link
Collaborator

hnla commented Nov 14, 2017

Hi @Saylrman64 Thanks for the feedback.

Firstly ought to point out that we have moved development of Nouveau to BP core or at least merged to core, further updates will happen there but to run you'll need to have a dev site setup running BP trunk form the SVN repo, I'll likely not have the time to try and keep the github repo up to date with changes in core although I'll be trying.

As to your problem I'm not 100% clear on what you think is missing? The BP tabbed feature styling for various BP menus relies on adding classes to parent elements based on the customizer option being selected so updating styling or overriding should just be a case of matching the selectors - more or less what you seem to demonstrate in your code snippet? You may need to look carefully for the classes as they are in different ancestral positions depending on menu.

if I have missed your point apologies and do clarify what it is or what might be a possible solution as you see it, which may help to see where we can improve things.

@Saylrman64
Copy link
Author

Hello,

Thank you for the prompt response. I will pull form svn to get the latest code and see how it all works.
It may be that what I'm looking for is right where it should be, but I must be looking at the latest code.

However, for clarity, With both the top and sub menu Show in Tab turned on in the Nouveau settings I looked through the elements using Inspect Code in Google Chrome. I was easily able to identify the required elements used to format the sub menu tabs (highlighting the block/div). But the top level menu tabs appeared to not actually have any border (showing as the sub menu did) and although I had highlighted the correct area on the tab code bock/div, there was no sign that classes had been defines to allow setting the css for tabs to show borders.

Once I look at the new or latest code, where do I post for help or clarification, if not here?

Thank you again.

@hnla
Copy link
Collaborator

hnla commented Nov 15, 2017

@Saylrman64 When you have identified the issue or an issue if you could post a ticket on the BP trac home we'll be able to look further:
https://buddypress.trac.wordpress.org/newticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants