Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support binding native boolean false on 5.36 and newer #129

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support binding native boolean false on 5.36 and newer #129

wants to merge 3 commits into from

Conversation

ilmari
Copy link
Collaborator

@ilmari ilmari commented Sep 27, 2024

Fixes #125

@ilmari ilmari mentioned this pull request Sep 27, 2024
Open
esabol
esabol suggested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@esabol esabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a Perl::Critic test that's failing, but I'm not clear as to what the problem there is.

Pg.pm Outdated Show resolved Hide resolved
@ilmari ilmari force-pushed the native-bools branch 2 times, most recently from 58fa82b to eb54373 Compare September 27, 2024 19:19
esabol
esabol approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@esabol esabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @ilmari !

@ilmari
Copy link
Collaborator Author

ilmari commented Sep 28, 2024

I just had a thought (and pushed a commit to do it, for discussion): should we respect pg_bool_tf and bind native booleans as t/f instead of 1/0 when it's set?

@ilmari ilmari force-pushed the native-bools branch 2 times, most recently from 7da168c to 67597c1 Compare September 28, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esabol esabol esabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v5.40's builtin false keyword cannot be passed in a bind parameter as the value of a boolean field
2 participants
@ilmari @esabol