Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other SVARs to be considered #13

Open
6 of 12 tasks
donotdespair opened this issue Mar 4, 2024 · 8 comments · Fixed by #24
Open
6 of 12 tasks

other SVARs to be considered #13

donotdespair opened this issue Mar 4, 2024 · 8 comments · Fixed by #24
Assignees
Labels
cpp code enhancement All the cpp stuff in here

Comments

@donotdespair
Copy link
Member

donotdespair commented Mar 4, 2024

Papers we should implement

SVARs

BVARs

Papers that are useful

Parallel computing

  • parallelize with OpenMP
  • progress bar with parallelization
@donotdespair donotdespair added the cpp code enhancement All the cpp stuff in here label Mar 4, 2024
@donotdespair donotdespair moved this to one beautiful day in bsvarPLANs Apr 5, 2024
adamwang15 added a commit that referenced this issue Jun 11, 2024
the scaling constant parameter c in metropolis-hastings
@adamwang15
Copy link
Collaborator

adamwang15 commented Jun 11, 2024

Development progress of Giannone, Lenza & Primiceri (2015, RESTAT) in branch develop-glp

  • log prior of hyper parameters
  • log marginal likelihood with dummy observations
  • log posterior of hyper parameters
  • mcmc algorithm
  • reproduce figure 1

@donotdespair
Copy link
Member Author

prepare a separate specify_* function and estimate method for the particular models by #14

  • RRWZ2010 with sign restrictions
  • ARRW2018 with zero and sign restrictions
  • ADRR2018 with sign and narrative restrictions
  • GLP2015 with estimated hyper-parameters

@adamwang15 adamwang15 linked a pull request Jun 17, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from one beautiful day to Done in bsvarPLANs Jun 17, 2024
@adamwang15 adamwang15 reopened this Jun 17, 2024
@donotdespair
Copy link
Member Author

Hey @adamwang15

I have finished work with specify_prior_bsvarSIGN. It is working well and passes all the relevant tests in inst/tinytest/test_specify.R. But it crashes other parts of the algo and I haven't yet introduced these changes. That's the upcoming task for the both of us!

Cheers, T

@adamwang15
Copy link
Collaborator

Great! (I think) I fixed the crash and now the code runs as usual, I will keep experimenting the GLP code!

@donotdespair
Copy link
Member Author

donotdespair commented Jul 2, 2024

On Robust Adaptive Metropolis (RAM) by Vihola (2012)

Hey @adamwang15 Amongst the Adaptive Metropolis algorithms we should try for the GLP model hyper-parameters sampler we should try the one by Vihola (2012). It is robust even for large dimensions of the candidate sampling density. There is an R package ramcmc implementing the RAM and it's written using RcppArmadillo. It is nice, small, and without other dependencies than Rcpp and RcppArmadillo. So, we could use it directly!

There's just one point we need to investigate: The RAM is designed for symmetric candidate generating densities. I am not sure how it'd work if one needs to use truncation (to avoid sampling negative variance coefficients). I'm investigating this.

  • The answer might be here (but I'm not implementing this): Tang & Yang (2024, JMLR)
  • software in R and C for the Adaptive Metropolis by Rosenthal is given on his website amcmc.

BTW, you were right about the meaning of $\alpha_i$. Nice! And also, that's much simpler than what I was coding!

Cheers, T

@adamwang15
Copy link
Collaborator

adamwang15 commented Jul 13, 2024

Hey @donotdespair thanks! Okay I missed this one! In the meantime, I coded an adaptive Metropolis algorithm and it seems to be working. This answer suggests log-transformation to sample positive parameters. I will try bringing in the ramcmc code, looks like it can be adjusted to include log-transformation as well.

  • use ramcmc for proposal variance in the Metropolis algorithm

@tomekey
Copy link

tomekey commented Mar 25, 2025

Hello, thanks for the great package! Have you considered implementing the 'pandemic priors' proposed by Cascaldi-Garcia? I think that'd be a very helpful addition.

@donotdespair
Copy link
Member Author

donotdespair commented Mar 26, 2025

Hey @tomekey Thanks for your post! Nice find!

We are planning to implement this model accommodating COVID period https://doi.org/10.1002/jae.2895. Pandemic priors look good. Have you seen any paper published on this (aha, I see from Danilo's website that there is a working paper. Still, we need a paper :) )? We need a paper well published.

... and a little time, as we need to strictly prioritise our tasks.

Stay in touch! We'll be publishing updates here 😄

Greetings, Tomasz @donotdespair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp code enhancement All the cpp stuff in here
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants