Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ProjectedEntangledPair ansatz #71

Merged
merged 12 commits into from
Jul 5, 2023
Merged

Implement ProjectedEntangledPair ansatz #71

merged 12 commits into from
Jul 5, 2023

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Jul 4, 2023

This PR closes #8. It implements an initial version of the ProjectedEntangledPair ansatz.
There are some things to do yet, like normalized random initialization, contraction or tests. But I would like to merge this now so we have more ansatzs than MPS to test functionalities.

@mofeing mofeing requested a review from jofrevalles July 4, 2023 15:58
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #71 (d40c923) into master (ca1f74a) will decrease coverage by 9.81%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   87.91%   78.10%   -9.81%     
==========================================
  Files           9       10       +1     
  Lines         629      708      +79     
==========================================
  Hits          553      553              
- Misses         76      155      +79     
Impacted Files Coverage Δ
src/Quantum/PEP.jl 0.00% <0.00%> (ø)
src/Quantum/Quantum.jl 73.73% <ø> (ø)
src/Tenet.jl 100.00% <ø> (ø)

Copy link
Member

@jofrevalles jofrevalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the new implementation and it seems to work fine. We will have to take a look at the random normalized initialization but we can do that in the future.

@mofeing mofeing merged commit e5be60d into master Jul 5, 2023
3 of 5 checks passed
@mofeing mofeing deleted the feature/peps branch July 5, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Projected Entangled Pair State (PEPS) and Operator (PEPO)
2 participants