Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excessive synchronization in contract on Dagger.DArray #124

Merged
merged 26 commits into from
May 30, 2024

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Nov 27, 2023

Closes #123

@mofeing mofeing linked an issue Nov 27, 2023 that may be closed by this pull request
Copy link
Member

@jofrevalles jofrevalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests? :)

@Todorbsc
Copy link
Contributor

Can we add some tests? :)

Yeah, we should. Currently, we are trying to fix some things in order to make the code work.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 80.46%. Comparing base (c2ef9db) to head (8129c7e).
Report is 18 commits behind head on master.

Current head 8129c7e differs from pull request most recent head 7231b46

Please upload reports for the commit 7231b46 to get more accurate results.

Files Patch % Lines
ext/TenetDaggerExt.jl 0.00% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   79.30%   80.46%   +1.16%     
==========================================
  Files          17       11       -6     
  Lines         865      640     -225     
==========================================
- Hits          686      515     -171     
+ Misses        179      125      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing
Copy link
Member Author

mofeing commented May 30, 2024

Updated the code to the last Tenet and Dagger changes. Also it now calls Tenet.contract instead of OMEinsum.EinCode.

@jofrevalles I also added some tests.

@mofeing mofeing requested a review from jofrevalles May 30, 2024 07:54
@mofeing mofeing merged commit 921b66b into master May 30, 2024
6 checks passed
@mofeing mofeing deleted the fix/contract-darray branch May 30, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specialize contract method for Dagger.DArray tensors
3 participants