-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix excessive synchronization in contract
on Dagger.DArray
#124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some tests? :)
Yeah, we should. Currently, we are trying to fix some things in order to make the code work. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 79.30% 80.46% +1.16%
==========================================
Files 17 11 -6
Lines 865 640 -225
==========================================
- Hits 686 515 -171
+ Misses 179 125 -54 ☔ View full report in Codecov by Sentry. |
31bf9fe
to
afb42be
Compare
Updated the code to the last @jofrevalles I also added some tests. |
Closes #123