Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename append! to merge! #102

Closed
mofeing opened this issue Oct 6, 2023 · 1 comment · Fixed by #103
Closed

Rename append! to merge! #102

mofeing opened this issue Oct 6, 2023 · 1 comment · Fixed by #103
Labels
good first issue Good for newcomers refactor Change internals
Milestone
0.4

Comments

@mofeing
Copy link
Member

mofeing commented Oct 6, 2023

Base.append! is thought for ordered collections like Vector, while Base.merge! is thought for key-indexed collections like Dict. Our TensorNetwork type resembles more a Dict since Tensors are not ordered and are key-indexed, so semantically makes more sense to use merge!.
@mofeing mofeing added good first issue Good for newcomers refactor Change internals labels Oct 6, 2023
@mofeing mofeing added this to the 0.4 milestone Oct 6, 2023
@mofeing mofeing mentioned this issue Oct 6, 2023
Merged
6 tasks
@mofeing mofeing linked a pull request Oct 6, 2023 that will close this issue
Refactor TensorNetwork to class-based OOP organization #103
Merged
6 tasks
@mofeing
Copy link
Member Author

mofeing commented Nov 3, 2023

Already fixed in some past commit.

@mofeing mofeing closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Change internals
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

Refactor TensorNetwork to class-based OOP organization bsc-quantic/Tenet.jl
1 participant
@mofeing