runPythonSource should allow additional options like debug, class, cache currently available only using script tag

[shlomil]

Current runPythonSource supports specifing only script_id:
__BRYTHON__.runPythonSource(src[, script_id])
However it does not allow setting additional options like class, debug , etc , forcing usage of the script tag.

Feature request:
If possible, have the function recieve an extra optinal parameter for additional options:
__BRYTHON__.runPythonSource(src[[, script_id], options])
example:
__BRYTHON__.runPythonSource(src, "main", {debug:"1"}])

[PierreQuentel]

Good point Shlomi ! In the commit referenced above I have changed the implementation of runPythonSource() so that the second argument can be either the script id (for compatibility with previous versions) or a JS object interpreted as the script attributes. Execution options can be passed this way.

I don't mark the issue as closed yet, could you check if the result works for you ?

[shlomil]

Thanks Pierre :)
I tested the following scenarios (uncomented each in a turn):

        //// (V) The second one appeared in devel tools network tab with the ?v=timestamp search param:
        //__BRYTHON__.runPythonSource("import some_module",{id: 'main1', cache:"1"})
        //__BRYTHON__.runPythonSource("import some_module2",{id: 'main2', cache:"0"})

        //// (V) The second one printed the js code that was generated:
        //__BRYTHON__.runPythonSource("import some_module",{id: 'main3', debug:"0"})
        //__BRYTHON__.runPythonSource("import some_module2",{id: 'main4', debug:"2"})

        //// (V) Import from one to the other - works
        //__BRYTHON__.runPythonSource("print('hello from imported modu1')",{id: 'modu1', debug:"0"})
        //__BRYTHON__.runPythonSource("import modu1",{id: 'main4', debug:"1"})

        //// (V) args - works
        //__BRYTHON__.runPythonSource("import sys;print(sys.argv)",{id: 'main4', args:["aaa","bbb","ccc"]})

        
        //// (?) returns python_script_769094014825749 - Shouldn't it be __main__ ?
        //// I expected runPythonScript to behave the same as <script> tag when no id is given however I guess there is logic
        //// in alllowing this in api call so the function could be called repeatedly with no additional arguments.
        //__BRYTHON__.runPythonSource("print(__name__)")


        //// (V) import from pythonpath
        //__BRYTHON__.runPythonSource("import sys;print(sys.path); import some_module",{id: 'main', pythonpath:["/somepath1/somepath2/"]})

All worked with the latest version. I couldn't make the following webworker example work:

        __BRYTHON__.runPythonSource(`
from browser import bind, self
@bind(self, "message")
def message(evt):
    result = 'pong' if evt.data == 'ping' else evt.data
    self.send(result)
`,{id:'worker','class':'webworker'})

        __BRYTHON__.runPythonSource(`
from browser import worker

def ready(w):
  w.send('ping')

def message(ev):
  print(ev.data)

worker.create_worker("worker", onready=ready, onmessage=message)
`,{id: 'main'})

It throws : RuntimeError: No webworker with id 'worker'
I did expect it to work since I expected to be able to do everything that can be done using a <script> tag.
I don't know if that's considered as a show stopper by you so I'll leave it to you to decide whether to close the bug or not.

Best regards,
Shlomi