Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests.rs : remplace usage of CSSlsrs' store by WEBlsp own store #1

Open
goulvenclech opened this issue Nov 24, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature ahead help wanted Extra attention is needed P2 - high Bugs that violates the documented behavior.

Comments

@goulvenclech
Copy link
Member

See fn get_language_id( in request.rs, used to dispatch the request to the appropriate language handler based on the current document's language id.

For now, we use CSSlsrs' store, because we only support CSS. So I can just retrieve the document from this store from its URI. Soon, WEBlsp will support multiple languages, and have its own store. The document will be retrieved from this store instead, and the stores for each language will be created with LANGlsrs::new_with_store() instead of LANGlsrs::new().

@goulvenclech goulvenclech self-assigned this Nov 24, 2024
goulvenclech added a commit that referenced this issue Nov 29, 2024
* more tests and more stuff

* fix(folding): correctly detect single-line region comments

* fix(folding): correctly handle nested region comments

* fix: wrong block kind

* feat(folding): Add benchmarks

* fix: run all benchs

* Actually, Erika wants us to use the text again

* fix: lint

* fix bed tests && tests in another file

* fix TS test

* perf(folding): reuse cached line indices

* fix lint

* doc: jsdoc on wasm function

* typo

---------

Co-authored-by: Erika <[email protected]>
goulvenclech added a commit that referenced this issue Nov 29, 2024
* more tests and more stuff

* fix(folding): correctly detect single-line region comments

* fix(folding): correctly handle nested region comments

* fix: wrong block kind

* feat(folding): Add benchmarks

* fix: run all benchs

* Actually, Erika wants us to use the text again

* fix: lint

* fix bed tests && tests in another file

* fix TS test

* perf(folding): reuse cached line indices

* fix lint

* doc: jsdoc on wasm function

* typo

---------

Co-authored-by: Erika <[email protected]>
goulvenclech added a commit that referenced this issue Nov 29, 2024
* more tests and more stuff

* fix(folding): correctly detect single-line region comments

* fix(folding): correctly handle nested region comments

* fix: wrong block kind

* feat(folding): Add benchmarks

* fix: run all benchs

* Actually, Erika wants us to use the text again

* fix: lint

* fix bed tests && tests in another file

* fix TS test

* perf(folding): reuse cached line indices

* fix lint

* doc: jsdoc on wasm function

* typo

---------

Co-authored-by: Erika <[email protected]>
@goulvenclech goulvenclech added enhancement New feature ahead help wanted Extra attention is needed P2 - high Bugs that violates the documented behavior. labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature ahead help wanted Extra attention is needed P2 - high Bugs that violates the documented behavior.
Projects
None yet
Development

No branches or pull requests

1 participant