Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New collection created with every bot interaction #27

Open
pchest opened this issue Mar 30, 2024 · 12 comments
Open

New collection created with every bot interaction #27

pchest opened this issue Mar 30, 2024 · 12 comments

Comments

@pchest
Copy link

pchest commented Mar 30, 2024

I am running your extension on Pop!_OS 22.04. Most features seem to work fine, but I noticed that with every interaction with the bot that a new collection is created. It isn't clear to me whether this is referring to the creation of a new data entry or the collection itself is being recreated with each interaction. If it's the latter, then I wouldn't expect there to be any persistent memory across sessions.

image

Additionally, there appears to be no measurable growth in the size of stored memories in qdrant over time, which further suggests that it's the collection that's recreated and that there is no persistent memory.

image

I'll be happy to run tests to see if persistent memory is in operation, or if it is not, to help resolve this issue.

Regardless, thank you for your time and effort on this project.

@brucepro
Copy link
Owner

Most likely due to space in botname. I have a bunch of fixes to push that are in the development branch. Will work this week on cleaning up and releasing.

@pchest
Copy link
Author

pchest commented Apr 1, 2024

@brucepro I tried changing the name to remove the space, but I'm having the same issue.

image

I look forward to seeing the new version!

@brucepro
Copy link
Owner

brucepro commented Apr 1, 2024

Are you able to view the qdrant dashboard?

@brucepro
Copy link
Owner

brucepro commented Apr 1, 2024

@pchest
Copy link
Author

pchest commented Apr 1, 2024

Yes, I am able to view the dashboard and verified that it contains the bot entry.

image

@brucepro
Copy link
Owner

brucepro commented Apr 1, 2024

Will setup a vm and test. May be related to os.

@pchest
Copy link
Author

pchest commented Apr 1, 2024

Got it. Thanks for looking into this. Let me know if you need any configuration information.

@v1ckxy
Copy link
Contributor

v1ckxy commented Jul 1, 2024

@brucepro I modified "create_vector_db_if_missing" definition to perform a check before trying to create something (plus a few more things), please have a look:
ebb20c3#diff-fe5b88e7d82b4e3af15a7050de06f0b0cd055eebce5c0227226911816418ad72

qdrant_client has the property collection_exists just to check if the collection already exists (returns true/false)
Looks like they added that API call in january.

Regards!

// And BTW, regarding character names, I found out another issue when deleting data (different name picked up from different places for the same char), I'll have a look at it soon.

@pchest
Copy link
Author

pchest commented Jul 1, 2024

Thank you for looking into this! I'll test this out later today and close the issue if it works.

@v1ckxy
Copy link
Contributor

v1ckxy commented Jul 1, 2024

TBH it was driving me nuts every time I saw the 409 (Conflict) in qdrant server log 🤣

@pchest
Copy link
Author

pchest commented Jul 1, 2024

Well, fixing it sounds like a win-win! lol

@brucepro
Copy link
Owner

brucepro commented Jul 2, 2024

So awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants