Skip to content

Commit c84cc53

Browse files
committed
Merge pull request #5 from browserstack/update_paths
Update paths
2 parents 2bf7dc8 + a7343c6 commit c84cc53

File tree

5 files changed

+17
-15
lines changed

5 files changed

+17
-15
lines changed

.eslintrc.json

-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
2,
99
"single"
1010
],
11-
"linebreak-style": [
12-
2,
13-
"unix"
14-
],
1511
"semi": [
1612
2,
1713
"always"

lib/Local.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function Local(){
1212
this.logfile = path.join(process.cwd(), 'local.log');
1313
this.exitCallback;
1414

15-
this.errorRegex = /\*\*\* Error: [^\n]+/i;
15+
this.errorRegex = /\*\*\* Error: [^\r\n]*/i;
1616
this.doneRegex = /Press Ctrl-C to exit/i;
1717

1818
this.start = function(options, callback){
@@ -46,7 +46,6 @@ function Local(){
4646
bytesRead += bytes;
4747

4848
var data = buffRead.toString();
49-
//console.log(data);
5049

5150
if(data.match(that.errorRegex)){
5251
fs.closeSync(that.stdout);

lib/LocalBinary.js

+9-7
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,23 @@ function LocalBinary(){
99
this.is64bits = process.arch == 'x64';
1010

1111
if(this.hostOS.match(/darwin|mac os/i)){
12-
this.httpPath = 'https://s3.amazonaws.com/bs-automate-prod/local/BrowserStackLocal-darwin-x64';
13-
} else if(this.hostOS.match(/mswin|msys|mingw|cygwin|bccwin|wince|emc/i)) {
12+
this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-darwin-x64';
13+
} else if(this.hostOS.match(/mswin|msys|mingw|cygwin|bccwin|wince|emc|win32/i)) {
1414
this.windows = true;
15-
this.httpPath = 'https://s3.amazonaws.com/bs-automate-prod/local/BrowserStackLocal-win32.exe';
15+
this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal.exe';
1616
} else {
1717
if(this.is64bits)
18-
this.httpPath = 'https://s3.amazonaws.com/bs-automate-prod/local/BrowserStackLocal-linux-x64';
18+
this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-linux-x64';
1919
else
20-
this.httpPath = 'https://s3.amazonaws.com/bs-automate-prod/local/BrowserStackLocal-linux-ia32';
20+
this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-linux-ia32';
2121
}
2222

2323
this.download = function(destParentDir, callback){
2424
if(!this.checkPath(destParentDir))
2525
fs.mkdirSync(destParentDir);
2626

27-
var binaryPath = path.join(destParentDir, 'BrowserStackLocal');
27+
var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
28+
var binaryPath = path.join(destParentDir, destBinaryName);
2829
var file = fs.createWriteStream(binaryPath);
2930

3031
https.get(this.httpPath, function (response) {
@@ -39,7 +40,8 @@ function LocalBinary(){
3940

4041
this.binaryPath = function(callback){
4142
var destParentDir = this.getAvailableDirs();
42-
var binaryPath = path.join(destParentDir, 'BrowserStackLocal');
43+
var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
44+
var binaryPath = path.join(destParentDir, destBinaryName);
4345
if(this.checkPath(binaryPath, fs.X_OK)){
4446
callback(binaryPath);
4547
} else {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"main": "index.js",
66
"scripts": {
77
"pretest": "./node_modules/.bin/eslint lib/* index.js",
8-
"test": "NODE_ENV=testing ./node_modules/.bin/mocha"
8+
"test": "./node_modules/.bin/mocha"
99
},
1010
"keywords": [
1111
"BrowserStack",

test/local.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
var expect = require('expect.js'),
22
mocks = require('mocks'),
3+
path = require('path'),
4+
fs = require('fs'),
35
browserstack = require('../index');
46

57
describe('Local', function () {
@@ -29,11 +31,13 @@ describe('Local', function () {
2931
this.timeout(60000);
3032
bsLocal.start({ key: process.env.BROWSERSTACK_ACCESS_KEY }, function(){
3133
bsLocal_2 = new browserstack.Local();
34+
var tempLogPath = path.join(process.cwd(), 'log2.log');
3235
try{
33-
bsLocal_2.start({ key: process.env.BROWSERSTACK_ACCESS_KEY }, function(){});
36+
bsLocal_2.start({ key: process.env.BROWSERSTACK_ACCESS_KEY, logfile: tempLogPath }, function(){});
3437
}
3538
catch(err){
3639
expect(err.toString().trim()).to.equal('LocalError: *** Error: Either another browserstack local client is running on your machine or some server is listening on port 45691');
40+
fs.unlinkSync(tempLogPath);
3741
done();
3842
}
3943
});
@@ -114,6 +118,7 @@ describe('Local', function () {
114118
});
115119

116120
afterEach(function (done) {
121+
this.timeout(60000);
117122
bsLocal.stop(done);
118123
});
119124

0 commit comments

Comments
 (0)