From 0ca8b1a74b2f92937b2a96017f4fefafd136ab9b Mon Sep 17 00:00:00 2001 From: Karan Nagpal Date: Thu, 7 Dec 2023 17:03:21 +0530 Subject: [PATCH] fix: undefined arg when request fails --- bin/commands/runs.js | 2 +- bin/helpers/atsHelper.js | 2 +- test/unit/bin/helpers/atsHelper.js | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bin/commands/runs.js b/bin/commands/runs.js index cbcd01a9..91e5a17b 100644 --- a/bin/commands/runs.js +++ b/bin/commands/runs.js @@ -154,7 +154,7 @@ module.exports = function run(args, rawArgs) { // Hence whenever running on ATS, need to make local as false bsConfig.connection_settings.local = false; - const gridDetails = await getTurboScaleGridDetails(bsConfig); + const gridDetails = await getTurboScaleGridDetails(bsConfig, args, rawArgs); if (gridDetails && Object.keys(gridDetails).length > 0) { Constants.turboScaleObj.gridDetails = gridDetails; diff --git a/bin/helpers/atsHelper.js b/bin/helpers/atsHelper.js index cb0898d8..6c8fef27 100644 --- a/bin/helpers/atsHelper.js +++ b/bin/helpers/atsHelper.js @@ -38,7 +38,7 @@ exports.getTurboScaleGridName = (bsConfig) => { return 'NO_GRID_NAME_PASSED'; }; -exports.getTurboScaleGridDetails = async (bsConfig) => { +exports.getTurboScaleGridDetails = async (bsConfig, args, rawArgs) => { try { const gridName = this.getTurboScaleGridName(bsConfig); diff --git a/test/unit/bin/helpers/atsHelper.js b/test/unit/bin/helpers/atsHelper.js index 0c005166..a8abae97 100644 --- a/test/unit/bin/helpers/atsHelper.js +++ b/test/unit/bin/helpers/atsHelper.js @@ -87,7 +87,7 @@ describe('#atsHelper', () => { requestStub.yields(null, { statusCode: 200 }, body); sendUsageReportStub.notCalled; - atsHelper.getTurboScaleGridDetails(testObjects.sampleATSBsConfigWithOptions).then((result) => { + atsHelper.getTurboScaleGridDetails(testObjects.sampleATSBsConfigWithOptions, {}, {}).then((result) => { expect(result).to.eq(body); }) }); @@ -104,7 +104,7 @@ describe('#atsHelper', () => { }; requestStub.yields(null, { statusCode: 422 }, body); - atsHelper.getTurboScaleGridDetails(testObjects.sampleATSBsConfigWithOptions).then((result) => { + atsHelper.getTurboScaleGridDetails(testObjects.sampleATSBsConfigWithOptions, {}, {}).then((result) => { expect(result).to.eq({}); expect(sendUsageReportStub.calledOnce).to.be.true; })