Control flow should propagate to "unconnected" call sites in inlined functions

[JustusAdam]

The control flow connection of user_data and println! in this example is correctly captured.

fn fixed(user_data: &PrivateUserData) -> bool {
    if user_data.key.len() > 10 {
        println!("key is longer than 10!");
        return true;
    }
}

However a refactoring into a separate function looses the connection:

fn broken(user_data: &PrivateUserData) -> bool {
    if user_data.key.len() > 10 {
        return print_and_return_true();
    }
}

fn print_and_return_true() -> bool {
    println!("key is longer than 10!");
    return true;
}

I think this could be one of two reasons. Either the PDG we construct doesn’t contain any call sites with no edges (unlikely I think) or alternatively we forward propagate the control flow influences from caller to callee based on edges from the entry nodes instead of just all nodes. Yikes.