Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd aliasing behavior in async functions #144

Open
JustusAdam opened this issue Apr 26, 2024 · 0 comments
Open

Odd aliasing behavior in async functions #144

JustusAdam opened this issue Apr 26, 2024 · 0 comments

Comments

@JustusAdam
Copy link
Collaborator

JustusAdam commented Apr 26, 2024 •
edited
Loading

Concerns the test case inlining_crate_local_async_fns from the async_tests suite. The value returned from get_user_data is not connected to the dp_user_data call, which receives a mutable reference and should read all reachable values upon function entry.
The same pattern is observed with immutable references in no_immutable_inlining_overtaint from the same suite.
@JustusAdam JustusAdam mentioned this issue Apr 26, 2024
Merged
5 tasks
JustusAdam added a commit that referenced this issue Apr 26, 2024
@JustusAdam
Merge the pdg construction from flowistry into this repo (#140)
3eaaa54 
## What Changed?

Merges the flowistry PDG into this repo. Contains updates to the
handling of async closures to have better field sensitivity.

Caveats: This merges an alias analysis bug #144. But I need main to
catch up and this bug does not appear to influence any use cases so I am
going ahead with this merge.

## Why Does It Need To?

This allows us to iterate faster on the actual construction algorithm.

## Checklist

- [x] Above description has been filled out so that upon quash merge we
have a
  good record of what changed.
- [x] New functions, methods, types are documented. Old documentation is
updated
  if necessary
- [ ] Documentation in Notion has been updated
- [ ] Tests for new behaviors are provided
  - [ ] New test suites (if any) ave been added to the CI tests (in
`.github/workflows/rust.yml`) either as compiler test or integration
test.
*Or* justification for their omission from CI has been provided in this
PR
    description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JustusAdam