Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency libcst to v1.6.0 #1255

Merged
merged 2 commits into from
Jan 11, 2025
Merged

fix(deps): update dependency libcst to v1.6.0 #1255

merged 2 commits into from
Jan 11, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2025 •
edited by sourcery-ai bot
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
libcst (changelog) ==1.5.1 -> ==1.6.0 age adoption passing confidence

Release Notes

Instagram/LibCST (libcst)

v1.6.0

Compare Source

Fixed

Added

Updated

New Contributors

Full Changelog: Instagram/LibCST@v1.5.1...v1.6.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Summary by Sourcery

Update LibCST to v1.6.0.

New Features:

  • Add codemods to convert typing.Union to |, fix variadic callable annotations, and rename typing aliases of builtins.
  • Expose TypeAlias and TypeVar related structs in the Rust library.

Enhancements:

  • Upgrade pyo3 to 0.22.

Tests:

  • Add typing classifier to pyproject.toml and badge to README.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 10, 2025
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jan 10, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This PR updates the libcst dependency from version 1.5.1 to 1.6.0. This update includes several bug fixes, new features, and improvements, as detailed in the changelog. Notably, it introduces new codemods, updates the pyo3 dependency, and addresses issues related to renaming and trailing commas.

Sequence diagram for improved rename functionality in LibCST 1.6.0

sequenceDiagram
    participant C as Client Code
    participant R as Rename System
    participant S as State Storage
    participant I as Import Handler

    C->>R: Request rename operation
    R->>S: Store state in scratch
    R->>I: Process imports
    I->>I: Handle parent module imports
    I->>I: Process aliased imports
    I->>R: Return processed imports
    R->>R: Handle trailing commas
    R->>R: Process toplevel names
    R->>C: Return transformed code
Loading

Class diagram showing new codemods in LibCST 1.6.0

classDiagram
    class UnionToOrCodemod {
        +transform_module()
        +transform_union_annotation()
    }
    note for UnionToOrCodemod "New codemod to convert typing.Union to |"

    class VariadicCallableCodemod {
        +transform_module()
        +fix_callable_annotation()
    }
    note for VariadicCallableCodemod "New codemod to fix variadic callable annotations"

    class TypeAliasRenameCodemod {
        +transform_module()
        +rename_builtin_aliases()
    }
    note for TypeAliasRenameCodemod "New codemod to rename typing aliases of builtins"

    class BaseCodemod {
        +transform_module()*
    }

    BaseCodemod <|-- UnionToOrCodemod
    BaseCodemod <|-- VariadicCallableCodemod
    BaseCodemod <|-- TypeAliasRenameCodemod
Loading

File-Level Changes

Change Details Files
Updated the libcst dependency
  • Updated libcst from version 1.5.1 to 1.6.0 in pyproject.toml
  • Regenerated the uv.lock file to reflect the dependency change
 pyproject.toml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Jan 10, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (10f3174) to head (9a99297).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          30       30           
  Lines        1026     1026           
  Branches      125      125           
=======================================
  Hits         1013     1013           
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@browniebroke browniebroke merged commit 9a25265 into main Jan 11, 2025
22 checks passed
@browniebroke browniebroke deleted the renovate/libcst-1.x branch January 11, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@browniebroke