Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keypress-listener.js & other Aframe event listeners #83

Open
RobertGemmaJr opened this issue Apr 18, 2022 · 1 comment
Open

keypress-listener.js & other Aframe event listeners #83

RobertGemmaJr opened this issue Apr 18, 2022 · 1 comment

Comments

@RobertGemmaJr
Copy link
Member

Event listeners for window, document, etc should be attached to a-scene not any individual entity.

Make sure the listeners update the volume immediately - force volume.js update function to run

Do we even need keypress-listener.js? Is turning the clipping on and off separately from the controls something the user desires?
@RobertGemmaJr
Copy link
Member Author

Combine all of the event listeners into a single file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RobertGemmaJr