Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block is not a valid parameter to iopub_channel get_msgs #13

Open
tcmulcahy opened this issue Jun 27, 2019 · 0 comments
Open

block is not a valid parameter to iopub_channel get_msgs #13

tcmulcahy opened this issue Jun 27, 2019 · 0 comments

Comments

@tcmulcahy
Copy link

https://github.com/broesler/jupyter-vim/blob/ca4296f/pythonx/jupyter_vim.py#L273 is
msgs = kc.iopub_channel.get_msgs(block=False)

This didn't work for me. According to https://github.com/jupyter/jupyter_client/blob/master/jupyter_client/blocking/channels.py#L59 get_msgs doesn't take any parameters (aside from self), and setting block to False is unnecessary since it only returns msgs that are currently ready.

block=True is a valid parameter to get_msg (singular) and it's what get_msgs uses internally.

tcmulcahy added a commit to tcmulcahy/jupyter-vim that referenced this issue Jun 27, 2019
get_msgs doesn't take such a parameter - it doesn't block.

This addresses broesler#13
broesler pushed a commit that referenced this issue Apr 10, 2020
Fix JupyterImportThisFile to PythonImportThisFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant