Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for absolute vertical alignment of text. #450

Open
easysid opened this issue Jan 13, 2018 · 7 comments · May be fixed by #1559
Open

Add support for absolute vertical alignment of text. #450

easysid opened this issue Jan 13, 2018 · 7 comments · May be fixed by #1559
Labels
enhancement Issue that suggests an enhancement text Issue or PR related to `conky.text` variables

Comments

@easysid
Copy link

easysid commented Jan 13, 2018 •
edited
Loading

Conky currently has a goto(x), but no corresponding goto(y) to align text vertically. A single goto(x,y) or a goto(y) would help minimize the use of voffset, which is prone to break layouts when fonts change.

Edit: I have got a working(?) version of this gotoy(), by just copying the code for goto(), and updating cur_y. I do not know how correct it is. If anyone is interested, have a look at easysid@f6ef58a
@mswanson-me mswanson-me added the enhancement Issue that suggests an enhancement label Feb 27, 2018
@lasers lasers assigned su8 and unassigned brndnmtthws and su8 Aug 31, 2018
@lasers
Copy link
Contributor

lasers commented Sep 3, 2018 •
edited
Loading

@su8 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺 🔺

@lasers lasers unassigned su8 Sep 29, 2018
@lasers lasers changed the title Request: Add support for absolute vertical alignment of text. Add support for absolute vertical alignment of text. Apr 3, 2019
@philer
Copy link

philer commented Nov 10, 2019 •
edited
Loading

So is this happening? Since @easysid has implemented this would it help if I just turn that commit into a PR? I could very much use this.

@su8
Copy link
Collaborator

su8 commented Nov 10, 2019

Just replace atoi with some of the strto* functions as with atoi you introduce undefined behavior.

@philer
Copy link

philer commented Nov 11, 2019

I don't know much about C, that's why I asked if it's enough to just turn the commit into a PR. I'll look into what you said, though. Maybe I can figure that much out. ;)

@easysid
Copy link
Author

easysid commented Nov 11, 2019

I can take a look at it at the weekend. I am out right now. Replacing atoi() with strtol() shouldn't be an issue, but my fork is now lagging a lot behind the parent repo.

@philer philer mentioned this issue Dec 2, 2019
Closed
@bi4k8 bi4k8 linked a pull request May 30, 2023 that will close this issue
Draft
4 tasks
@github-actions
Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment, or this issue will be closed in 30 days.

@github-actions github-actions bot added the Stale Issue/PR that requires attention because it hasn't been updated in over a year label Oct 21, 2023
@philer
Copy link

philer commented Oct 21, 2023

Still relevant, IMHO

@github-actions github-actions bot removed the Stale Issue/PR that requires attention because it hasn't been updated in over a year label Oct 22, 2023
@Caellian Caellian added the text Issue or PR related to `conky.text` variables label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue that suggests an enhancement text Issue or PR related to `conky.text` variables
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement vgoto bi4k8/conky
7 participants
@lasers @brndnmtthws @easysid @Caellian @philer @su8 @mswanson-me