Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions not triggering #99

Closed
rawktron opened this issue Oct 4, 2023 · 1 comment · Fixed by #100
Closed

Transitions not triggering #99

rawktron opened this issue Oct 4, 2023 · 1 comment · Fixed by #100

Comments

@rawktron
Copy link
Contributor

rawktron commented Oct 4, 2023

Hi, as requested, here's a minimal project that reproduces the transitions not triggering. I'm assuming that I'm not doing something properly. But this is a minimal setup based on the information in the docs. The screen does display (in the test it's at 0,0 and it's just in the bottom left, but same behaviour with any location), and there are no errors output in the console. Thanks!

transitions.zip

@rawktron
Copy link
Contributor Author

rawktron commented Oct 4, 2023

Ok, I think I found the issue. I will open a PR with a fix. Line 512:

screen.transition_url = screen.factory_ids[screen.transition_id]

...but earlier on line 325, it's set to nil because screen.transition_id is deprecated.

PR here: #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant