Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed URLs when using nested collections #95

Closed
dri-richard opened this issue Aug 2, 2023 · 1 comment
Closed

Malformed URLs when using nested collections #95

dri-richard opened this issue Aug 2, 2023 · 1 comment

Comments

@dri-richard
Copy link

(release 4.1.0)

If a screen proxy is in a collection which is in another collection, then its transition_url / focus_url / receiver_url properties are malformed, and the code to detect them in monarch.lua register_proxy() won't detect them.

To reproduce:

  • Create a collection file called e.g. advanced_parent in folder example/advanced
  • Add advanced.collection to the new collection
  • Set advanced_parent.collection as the main collection in game.project
  • Set a breakpoint in init() of screen_proxy.script
  • Run
image
@britzl
Copy link
Owner

britzl commented Aug 3, 2023

Thanks. I've solved the issue in df2a2a6

@britzl britzl closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants