Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show(nostack=true) + hide = bad behaviour #78

Closed
Morgerion opened this issue Jul 14, 2021 · 7 comments
Closed

show(nostack=true) + hide = bad behaviour #78

Morgerion opened this issue Jul 14, 2021 · 7 comments
Labels
more info More information is needed before any action can be taken

Comments

@Morgerion
Copy link

Here is a screenshot of the situation:
image_2021-07-14_16-23-09

There is a window hint_info.
It opens with show(nostack=true).
It closes with hide().

Details of the problem:

  1. hint_info window has a checkbox to keep the focus for the parent window. But when hint_info is opened, parent window loses focus permanently.
  2. hint_info window has a popup type, but the parent window is still removed from the stack and there is no return to it after hide().

On version 3.3.0 there were no such problems - this code worked correctly.

@britzl
Copy link
Owner

britzl commented Jul 19, 2021

It opens with show(nostack=true).

  1. hint_info window has a checkbox to keep the focus for the parent window

Hmm, but if it is not added to the stack it shouldn't have a parent window at all. Why is it shown with nostack=true if you want it to interact with windows in the stack?

@britzl britzl added the more info More information is needed before any action can be taken label Jul 22, 2021
@britzl
Copy link
Owner

britzl commented Aug 2, 2021

@Morgerion any update?

@Morgerion
Copy link
Author

I apologise, perhaps I didn't describe the problem well.

So.
Yes, we have a window with no-stack.
Problem №1: when we open it, the parent window loses its input/focus, even though the no-stack window has checkbox "others keep input focus when below...".
Problem №2: closing a window with a non-stack removes the parent window from the stack! O_O

This seems to me to be a strange behavior for a no-stack window.
As a reminder, everything worked fine before.

We solved this problem simply by getting rid of the no-stack window.

@britzl
Copy link
Owner

britzl commented Aug 19, 2021

Sorry for the late reply. Thank you for clarifying the problem.

  • Issue no.2 is definitely a bug. A screen that is shown with no_stack should never in any way manipulate the stack.
  • Issue no.1. is a bit tricker. The no_stack option was mainly created as a way to load and hide screens without interaction, such as a background image or similar. I'm actually not able to reproduce the problem. Can you tell me a bit more about the two screens? Were they both normal screens or was one or both of them popups?

@Morgerion
Copy link
Author

One window (parent) is a normal full-screen in-stack window.
The second window (popup) is an no-stack popup.

Unfortunately I can't reproduce this problem now either, because we solved it a long time ago by doing away with no-stack windows. You can try to reproduce the same settings I have shown in the screenshot above.

@britzl
Copy link
Owner

britzl commented Aug 19, 2021

Thanks. I'll see if I can repro the problem. But I think it is better to be careful with no_stack windows and use them mainly for static things such as backgrounds

@britzl
Copy link
Owner

britzl commented Sep 19, 2021

Thanks. I'll see if I can repro the problem

I'm unable to reproduce the problem. Closing this issue for now.

@britzl britzl closed this as completed Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info More information is needed before any action can be taken
Projects
None yet
Development

No branches or pull requests

2 participants