Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error in docs (using transitions) #102

Closed
ProgrammingLife opened this issue Dec 21, 2023 · 0 comments
Closed

An error in docs (using transitions) #102

ProgrammingLife opened this issue Dec 21, 2023 · 0 comments

Comments

@ProgrammingLife
Copy link

ProgrammingLife commented Dec 21, 2023

Here: https://github.com/britzl/monarch/blob/master/README_TRANSITIONS.md there is a line:

self.transition.window_resized(message.width, message.height)

but window_resized() is not exist in the current transition instance. It's in the transitions instance:

Looks it should be:

transitions.window_resized(message.width, message.height)

Explanation:
If we look at the source: https://github.com/britzl/monarch/blob/master/monarch/transitions/gui.lua then we see that window_resized() method returns directly to a root reference of the module which is imported as:

local transitions = require "..." 

And vice versa:

local transition = transitions.create()
pprint( transition ) 

There is no window_resized() method there.

@britzl britzl closed this as completed in ce5ca26 Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant