Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.close() throws errors when mock: true is set #273

Open
Mnkras opened this issue Sep 18, 2024 · 1 comment
Open

client.close() throws errors when mock: true is set #273

Mnkras opened this issue Sep 18, 2024 · 1 comment

Comments

@Mnkras
Copy link

Mnkras commented Sep 18, 2024

With mock: true my understanding is no metrics will be emitted and metrics just end up in a local buffer.

When calling client.close() it attempts to create a socket, and if it can't connect will spew errors. I think if mock: true is set , it should just return.

Thoughts?

@bdeitte
Copy link
Collaborator

bdeitte commented Sep 22, 2024

That makes sense to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants